This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20746 ) Change subject: ipc: Use OSMO_FD_* instead of deprecated BSC_FD_* ...................................................................... ipc: Use OSMO_FD_* instead of deprecated BSC_FD_* Change-Id: I98b3f9525954d6882f7488d650038a8e28f7b769 --- M Transceiver52M/device/ipc/IPCDevice.cpp M Transceiver52M/device/ipc/ipc-driver-test.c M Transceiver52M/device/ipc/ipc_chan.c M Transceiver52M/device/ipc/ipc_sock.c 4 files changed, 25 insertions(+), 25 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/Transceiver52M/device/ipc/IPCDevice.cpp b/Transceiver52M/device/ipc/IPCDevice.cpp index 32a46e5..102cb9b 100644 --- a/Transceiver52M/device/ipc/IPCDevice.cpp +++ b/Transceiver52M/device/ipc/IPCDevice.cpp @@ -522,7 +522,7 @@ return -EIO; } msgb_enqueue(&state->upqueue, msg); - conn_bfd->when |= BSC_FD_WRITE; + conn_bfd->when |= OSMO_FD_WRITE; return 0; } @@ -659,7 +659,7 @@ msg = llist_entry(master_sk_state.upqueue.next, struct msgb, list); ipc_prim = (struct ipc_sk_if *)msg->data; - bfd->when &= ~BSC_FD_WRITE; + bfd->when &= ~OSMO_FD_WRITE; /* bug hunter 8-): maybe someone forgot msgb_put(...) ? */ if (!msgb_length(msg)) { @@ -676,7 +676,7 @@ goto close; if (rc < 0) { if (errno == EAGAIN) { - bfd->when |= BSC_FD_WRITE; + bfd->when |= OSMO_FD_WRITE; break; } goto close; @@ -706,7 +706,7 @@ /* peek at the beginning of the queue */ msg = llist_entry(sk_chan_state[bfd->priv_nr].upqueue.next, struct msgb, list); ipc_prim = (struct ipc_sk_chan_if *)msg->data; - bfd->when &= ~BSC_FD_WRITE; + bfd->when &= ~OSMO_FD_WRITE; /* bug hunter 8-): maybe someone forgot msgb_put(...) ? */ if (!msgb_length(msg)) { LOGP(DDEV, LOGL_ERROR, @@ -722,7 +722,7 @@ goto close; if (rc < 0) { if (errno == EAGAIN) { - bfd->when |= BSC_FD_WRITE; + bfd->when |= OSMO_FD_WRITE; break; } goto close; @@ -746,12 +746,12 @@ IPCDevice *device = static_cast<IPCDevice *>(bfd->data); int rc = 0; - if (flags & BSC_FD_READ) + if (flags & OSMO_FD_READ) rc = device->ipc_sock_read(bfd); if (rc < 0) return rc; - if (flags & BSC_FD_WRITE) + if (flags & OSMO_FD_WRITE) rc = device->ipc_sock_write(bfd); return rc; @@ -762,12 +762,12 @@ IPCDevice *device = static_cast<IPCDevice *>(bfd->data); int rc = 0; - if (flags & BSC_FD_READ) + if (flags & OSMO_FD_READ) rc = device->ipc_chan_sock_read(bfd); if (rc < 0) return rc; - if (flags & BSC_FD_WRITE) + if (flags & OSMO_FD_WRITE) rc = device->ipc_chan_sock_write(bfd); return rc; diff --git a/Transceiver52M/device/ipc/ipc-driver-test.c b/Transceiver52M/device/ipc/ipc-driver-test.c index 44c8b0e..0cccbda 100644 --- a/Transceiver52M/device/ipc/ipc-driver-test.c +++ b/Transceiver52M/device/ipc/ipc-driver-test.c @@ -394,7 +394,7 @@ return -1; } - bfd->when = BSC_FD_READ; + bfd->when = OSMO_FD_READ; bfd->cb = sock_callback_fn; bfd->data = state; bfd->priv_nr = n; diff --git a/Transceiver52M/device/ipc/ipc_chan.c b/Transceiver52M/device/ipc/ipc_chan.c index 9e35fb2..af18aab 100644 --- a/Transceiver52M/device/ipc/ipc_chan.c +++ b/Transceiver52M/device/ipc/ipc_chan.c @@ -142,7 +142,7 @@ return -EIO; } msgb_enqueue(&state->upqueue, msg); - conn_bfd->when |= BSC_FD_WRITE; + conn_bfd->when |= OSMO_FD_WRITE; return 0; } @@ -160,7 +160,7 @@ msg = llist_entry(state->upqueue.next, struct msgb, list); ipc_prim = (struct ipc_sk_chan_if *)msg->data; - bfd->when &= ~BSC_FD_WRITE; + bfd->when &= ~OSMO_FD_WRITE; /* bug hunter 8-): maybe someone forgot msgb_put(...) ? */ if (!msgb_length(msg)) { @@ -177,7 +177,7 @@ goto close; if (rc < 0) { if (errno == EAGAIN) { - bfd->when |= BSC_FD_WRITE; + bfd->when |= OSMO_FD_WRITE; break; } goto close; @@ -200,12 +200,12 @@ { int rc = 0; - if (flags & BSC_FD_READ) + if (flags & OSMO_FD_READ) rc = ipc_chan_sock_read(bfd); if (rc < 0) return rc; - if (flags & BSC_FD_WRITE) + if (flags & OSMO_FD_WRITE) rc = ipc_chan_sock_write(bfd); return rc; @@ -231,13 +231,13 @@ "osmo-trx connects but we already have " "another active connection ?!?\n"); /* We already have one IPC connected, this is all we support */ - state->listen_bfd.when &= ~BSC_FD_READ; + state->listen_bfd.when &= ~OSMO_FD_READ; close(rc); return 0; } conn_bfd->fd = rc; - conn_bfd->when = BSC_FD_READ; + conn_bfd->when = OSMO_FD_READ; conn_bfd->cb = ipc_chan_sock_cb; conn_bfd->data = state; diff --git a/Transceiver52M/device/ipc/ipc_sock.c b/Transceiver52M/device/ipc/ipc_sock.c index 435dc3c..26865bf 100644 --- a/Transceiver52M/device/ipc/ipc_sock.c +++ b/Transceiver52M/device/ipc/ipc_sock.c @@ -84,7 +84,7 @@ return -EIO; } msgb_enqueue(&state->upqueue, msg); - conn_bfd->when |= BSC_FD_WRITE; + conn_bfd->when |= OSMO_FD_WRITE; return 0; } @@ -102,7 +102,7 @@ osmo_fd_unregister(bfd); /* re-enable the generation of ACCEPT for new connections */ - state->listen_bfd.when |= BSC_FD_READ; + state->listen_bfd.when |= OSMO_FD_READ; /* flush the queue */ while (!llist_empty(&state->upqueue)) { @@ -172,7 +172,7 @@ msg = llist_entry(state->upqueue.next, struct msgb, list); ipc_prim = (struct ipc_sk_if *)msg->data; - bfd->when &= ~BSC_FD_WRITE; + bfd->when &= ~OSMO_FD_WRITE; /* bug hunter 8-): maybe someone forgot msgb_put(...) ? */ if (!msgb_length(msg)) { @@ -189,7 +189,7 @@ goto close; if (rc < 0) { if (errno == EAGAIN) { - bfd->when |= BSC_FD_WRITE; + bfd->when |= OSMO_FD_WRITE; break; } goto close; @@ -212,12 +212,12 @@ { int rc = 0; - if (flags & BSC_FD_READ) + if (flags & OSMO_FD_READ) rc = ipc_sock_read(bfd); if (rc < 0) return rc; - if (flags & BSC_FD_WRITE) + if (flags & OSMO_FD_WRITE) rc = ipc_sock_write(bfd); return rc; @@ -244,13 +244,13 @@ "ip clent connects but we already have " "another active connection ?!?\n"); /* We already have one IPC connected, this is all we support */ - state->listen_bfd.when &= ~BSC_FD_READ; + state->listen_bfd.when &= ~OSMO_FD_READ; close(rc); return 0; } conn_bfd->fd = rc; - conn_bfd->when = BSC_FD_READ; + conn_bfd->when = OSMO_FD_READ; conn_bfd->cb = ipc_sock_cb; conn_bfd->data = state; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20746 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I98b3f9525954d6882f7488d650038a8e28f7b769 Gerrit-Change-Number: 20746 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201018/cdfb3b8f/attachment.htm>