This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/20729 ) Change subject: power_control: do nothing if 'rx-current' equals 'rx-target' ...................................................................... power_control: do nothing if 'rx-current' equals 'rx-target' It makes no sense to do further calculations if the actual Uplink signal strength equals the target value configured in the VTY. Change-Id: Id99c7013a722403e773df8367b1a9d7a856e639b Related: SYS#4916 --- M src/common/power_control.c M tests/power/power_test.err 2 files changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/29/20729/1 diff --git a/src/common/power_control.c b/src/common/power_control.c index 4b08b21..cf5ecf7 100644 --- a/src/common/power_control.c +++ b/src/common/power_control.c @@ -147,6 +147,16 @@ "Diff between 'rx-target' %d dBm and 'rx-current' %d dBm is %d dBm\n", bts->ul_power_target, avg_ul_rssi_dbm, diff); + /* TODO: introduce 'delta' defining a range of tolerable deviation */ + if (diff == 0) { + LOGPLCHAN(lchan, DLOOP, LOGL_INFO, + "Keeping MS power at control level %d (%d dBm) because diff %d dBm " + "from 'rx-target' %d dBm is not significant\n", + ms_power_lvl, ms_dbm, diff, bts->ul_power_target); + lchan->ms_power_ctrl.current = ms_power_lvl; + return 0; + } + /* don't ever change more than MS_{LOWER,RAISE}_MAX_DBM during one loop iteration, i.e. reduce the speed at which the MS transmit power can change. A higher value means a lower level (and vice versa) */ diff --git a/tests/power/power_test.err b/tests/power/power_test.err index 264e871..8368f57 100644 --- a/tests/power/power_test.err +++ b/tests/power/power_test.err @@ -11,7 +11,7 @@ (bts=0,trx=0,ts=0,ss=0) Diff between 'rx-target' -75 dBm and 'rx-current' -90 dBm is 15 dBm (bts=0,trx=0,ts=0,ss=0) Raising MS power from control level 7 (16 dBm) to 5, 20 dBm (rx-ms-pwr-lvl 7, max-ms-pwr-lvl 2, rx-current -90 dBm, rx-target -75 dBm) (bts=0,trx=0,ts=0,ss=0) Diff between 'rx-target' -75 dBm and 'rx-current' -75 dBm is 0 dBm -(bts=0,trx=0,ts=0,ss=0) Keeping MS power at control level 5, 20 dBm (rx-ms-pwr-lvl 5, max-ms-pwr-lvl 2, rx-current -75 dBm, rx-target -75 dBm) +(bts=0,trx=0,ts=0,ss=0) Keeping MS power at control level 5 (20 dBm) because diff 0 dBm from 'rx-current' -75 dBm is not significant (bts=0,trx=0,ts=0,ss=0) Diff between 'rx-target' -75 dBm and 'rx-current' -90 dBm is 15 dBm (bts=0,trx=0,ts=0,ss=0) Raising MS power from control level 5 (20 dBm) to 3, 24 dBm (rx-ms-pwr-lvl 5, max-ms-pwr-lvl 2, rx-current -90 dBm, rx-target -75 dBm) (bts=0,trx=0,ts=0,ss=0) Diff between 'rx-target' -75 dBm and 'rx-current' -90 dBm is 15 dBm @@ -29,7 +29,7 @@ (bts=0,trx=0,ts=0,ss=0) Diff between 'rx-target' -75 dBm and 'rx-current' -90 dBm is 15 dBm (bts=0,trx=0,ts=0,ss=0) Keeping MS power at control level 29, 36 dBm (rx-ms-pwr-lvl 29, max-ms-pwr-lvl 29, rx-current -90 dBm, rx-target -75 dBm) (bts=0,trx=0,ts=0,ss=0) Diff between 'rx-target' -75 dBm and 'rx-current' -75 dBm is 0 dBm -(bts=0,trx=0,ts=0,ss=0) Keeping MS power at control level 29, 36 dBm (rx-ms-pwr-lvl 29, max-ms-pwr-lvl 29, rx-current -75 dBm, rx-target -75 dBm) +(bts=0,trx=0,ts=0,ss=0) Keeping MS power at control level 29 (36 dBm) because diff 0 dBm from 'rx-current' -75 dBm is not significant (bts=0,trx=0,ts=0,ss=0) Diff between 'rx-target' -75 dBm and 'rx-current' -45 dBm is -30 dBm (bts=0,trx=0,ts=0,ss=0) Lowering MS power from control level 29 (36 dBm) to 1, 28 dBm (rx-ms-pwr-lvl 29, max-ms-pwr-lvl 29, rx-current -45 dBm, rx-target -75 dBm) (bts=0,trx=0,ts=0,ss=0) Diff between 'rx-target' -75 dBm and 'rx-current' -45 dBm is -30 dBm @@ -45,7 +45,7 @@ (bts=0,trx=0,ts=0,ss=0) Diff between 'rx-target' -75 dBm and 'rx-current' -40 dBm is -35 dBm (bts=0,trx=0,ts=0,ss=0) Lowering MS power from control level 14 (2 dBm) to 15, 0 dBm (rx-ms-pwr-lvl 14, max-ms-pwr-lvl 0, rx-current -40 dBm, rx-target -75 dBm) (bts=0,trx=0,ts=0,ss=0) Diff between 'rx-target' -75 dBm and 'rx-current' -75 dBm is 0 dBm -(bts=0,trx=0,ts=0,ss=0) Keeping MS power at control level 15, 0 dBm (rx-ms-pwr-lvl 15, max-ms-pwr-lvl 2, rx-current -75 dBm, rx-target -75 dBm) +(bts=0,trx=0,ts=0,ss=0) Keeping MS power at control level 15 (0 dBm) because diff 0 dBm from 'rx-current' -75 dBm is not significant (bts=0,trx=0,ts=0,ss=0) Diff between 'rx-target' -75 dBm and 'rx-current' -78 dBm is 3 dBm (bts=0,trx=0,ts=0,ss=0) Raising MS power from control level 15 (0 dBm) to 13, 3 dBm (rx-ms-pwr-lvl 15, max-ms-pwr-lvl 2, rx-current -78 dBm, rx-target -75 dBm) (bts=0,trx=0,ts=0,ss=0) Diff between 'rx-target' -75 dBm and 'rx-current' -80 dBm is 5 dBm -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id99c7013a722403e773df8367b1a9d7a856e639b Gerrit-Change-Number: 20729 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201018/d22762b4/attachment.htm>