Change in osmo-bts[master]: scheduler: drop redundant check in trx_sched_set_cipher()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Oct 18 11:06:11 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/20720 )


Change subject: scheduler: drop redundant check in trx_sched_set_cipher()
......................................................................

scheduler: drop redundant check in trx_sched_set_cipher()

In this function we already do check that a given timeslot is not
a PDCH slot, so checking if TRX_CHAN_FLAG_PDCH is redundant.

Change-Id: Ie73bdaf0f6bc76ed8d2e95d1fb995333bf617e7e
---
M src/common/scheduler.c
1 file changed, 0 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/20/20720/1

diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 33de158..6d359e0 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -1102,9 +1102,6 @@
 
 	/* look for all matching chan_nr */
 	for (i = 0; i < _TRX_CHAN_MAX; i++) {
-		/* skip if pchan type */
-		if (trx_chan_desc[i].flags & TRX_CHAN_FLAG_PDCH)
-			continue;
 		if (trx_chan_desc[i].chan_nr == (chan_nr & RSL_CHAN_NR_MASK)) {
 			chan_state = &l1ts->chan_state[i];
 			LOGP(DL1C, LOGL_NOTICE, "Set a5/%d %s for %s on trx=%d "

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20720
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie73bdaf0f6bc76ed8d2e95d1fb995333bf617e7e
Gerrit-Change-Number: 20720
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201018/9114ed64/attachment.htm>


More information about the gerrit-log mailing list