Change in osmo-bts[master]: scheduler: drop Uplink SACCH loss detection from Downlink path

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Oct 16 10:33:48 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20674 )

Change subject: scheduler: drop Uplink SACCH loss detection from Downlink path
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1: Code-Review-1
> > 
> > This should be kept in case we interact with a TRXDv0 TRX. There's at least one known TRXDv0 implementation which didn't move to TRXDv1, so I'd keep it for now.
> 
> I don't think we should keep this hack just because some [proprietary] implementations still do not support TRXDv1. Moreover, this approach is far from a good solution: a) there is a significant delay between Uplink and Downlink (fn-advance + rts-advance + 3 timeslots), so the compensated frames are too late; b) why should up to date TRXDv1 users waste additional CPU resources? c) if the gap between bursts is not huge, trx_sched_calc_frame_loss() would compensate the missing bursts faster.

I'm simply asking to delay removal of this code for a while.
TRXdv1 wasting additional resource: That's precisely what I'm asking, simply make this conditional based on TRXDv0 being used instead of dropping it. I'm fine with keeping a separate patch dropping it in gerrit but not yet merged until we can smotthly transition to trxdv1 in that implementation.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20674
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic292d180ba64206fb4d88adb284f9f9d058b4587
Gerrit-Change-Number: 20674
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Oct 2020 10:33:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201016/ea85bfab/attachment.htm>


More information about the gerrit-log mailing list