Change in osmo-msc[master]: emergency: set route-to-msisdn MSISDN to 112 by default.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Oct 15 20:20:17 UTC 2020


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/20672 )


Change subject: emergency: set route-to-msisdn MSISDN to 112 by default.
......................................................................

emergency: set route-to-msisdn MSISDN to 112 by default.

When the vty variable emergency-call route-to-msisdn MSISDN is not set
to any value, the default is an empty string. This is problematic, since
it causes emergency calls to fail even when emergency calls are properly
enabled. It is not immediately obvious to the user that the
route-to-msisdn variable has to be set as well. Lets set route-to-msisdn
to 112 by default to have a sane default here.

Change-Id: I8a600cef105c0d67a9991e14b2187e26eacb01ec
Related: OS#4549 SYS#4914
---
M include/osmocom/msc/msc_common.h
M src/osmo-msc/msc_main.c
2 files changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/72/20672/1

diff --git a/include/osmocom/msc/msc_common.h b/include/osmocom/msc/msc_common.h
index 8a43e69..4b5507e 100644
--- a/include/osmocom/msc/msc_common.h
+++ b/include/osmocom/msc/msc_common.h
@@ -15,6 +15,8 @@
 #define MSC_HLR_REMOTE_IP_DEFAULT "127.0.0.1"
 #define MSC_HLR_REMOTE_PORT_DEFAULT OSMO_GSUP_PORT
 
+#define MSC_EMEGENCY_ROUTE_TO_MSISDN_DEFAULT "112"
+
 /* TS 48.008 DLCI containing DCCH/ACCH + SAPI */
 #define OMSC_LINKID_CB(__msgb)   (__msgb)->cb[3]
 
diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index 4f614db..3f45a68 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -233,6 +233,8 @@
 						  MSC_HLR_REMOTE_IP_DEFAULT);
 	net->gsup_server_port = MSC_HLR_REMOTE_PORT_DEFAULT;
 
+	net->emergency.route_to_msisdn = talloc_strdup(net, MSC_EMEGENCY_ROUTE_TO_MSISDN_DEFAULT);
+
 	mgcp_client_conf_init(&net->mgw.conf);
 	net->call_waiting = true;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/20672
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8a600cef105c0d67a9991e14b2187e26eacb01ec
Gerrit-Change-Number: 20672
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201015/433878e1/attachment.htm>


More information about the gerrit-log mailing list