Change in osmo-bsc[master]: cosmetic: shorten: add g_smlc macro for 'bsc_gsmnet->smlc'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Oct 15 10:57:32 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20650 )

Change subject: cosmetic: shorten: add g_smlc macro for 'bsc_gsmnet->smlc'
......................................................................


Patch Set 1:

I'm not really liking this macro approach, it looks hacky for no good reason. I'd rather simply store it in a local variable whenever ultiple uses of the pointer are used.

In any case, imho the macro should be put by the side of where the "extern bsc_gsmnet" is defined.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20650
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I28058db2ac77ea176398764733e3ef86ef6ff06d
Gerrit-Change-Number: 20650
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Oct 2020 10:57:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201015/87de80c1/attachment.htm>


More information about the gerrit-log mailing list