Change in osmo-bts[master]: sysinfo: Don't broadcast SI4 GPRS INDICATOR if PCU is disconnected

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Oct 15 06:09:22 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20543 )

Change subject: sysinfo: Don't broadcast SI4 GPRS INDICATOR if PCU is disconnected
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/20543/1/src/common/sysinfo.c 
File src/common/sysinfo.c:

https://gerrit.osmocom.org/c/osmo-bts/+/20543/1/src/common/sysinfo.c@a201 
PS1, Line 201: SI3
> Ack
the point is that the variable is now called bts->si_gprs_ind_disabled and it determines whether A GPRS indicator is present in any of the SI types (or not).  The position in the code where we change the variable (and hence print the message) does affect other code.  So keeping the SI type printed here would be extremely misleading.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20543
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fd513ea03297918d15d4b28ed454f9b6dd6ebfa
Gerrit-Change-Number: 20543
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Oct 2020 06:09:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201015/7757c7c5/attachment.htm>


More information about the gerrit-log mailing list