Change in osmo-bsc[master]: BSSMAP RESET: generalize a_reset FSM

[neels]

Hello Jenkins Builder, pespin, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-bsc/+/20625

to look at the new patch set (#2).

Change subject: BSSMAP RESET: generalize a_reset FSM
......................................................................

BSSMAP RESET: generalize a_reset FSM

Separate the a_reset FSM implementation from BSSMAP and MSC specifics, so that
it can be re-used on the Lb interface.

Move the FSM implementation to bssmap_reset.c and tweak, to match common practices we
have generally established in our osmo_fsm implementations.

Keep a_reset.h and a_reset.c and redirect to bssmap_reset.c.

A difficulty is setting a proper logging category: the FSM definition allows
only one fixed logging category for FSM state transitions and events. Ideally,
the BSSMAP reset fsm would log on DMSC, and the BSSMAP-LE reset fsm would log
on DLCS. Since that is not possible, introduce a separate DRESET logging
category. This in fact matches an item on my wishlist, because if a given MSC
is configured but currently not connected, the previous RESET FSM would
continuously "spam" log LOGL_NOTICE messages indicating that it is resending
RESET, and I often want to silence those messages without silencing the entire
DMSC category. This is now easily possible by setting DRESET logging to
LOGL_ERROR. There is additional "link up" / "link lost" logging on DMSC, so all
interesting info is still visible on DMSC.

Change-Id: Ib3c3a163186c40a93be0dea666230431172136df
---
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/a_reset.h
M include/osmocom/bsc/bsc_msc_data.h
A include/osmocom/bsc/bssmap_reset.h
M include/osmocom/bsc/debug.h
M include/osmocom/bsc/osmo_bsc_sigtran.h
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/a_reset.c
A src/osmo-bsc/bssmap_reset.c
M src/osmo-bsc/osmo_bsc_main.c
M src/osmo-bsc/osmo_bsc_sigtran.c
M tests/handover/handover_test.c
12 files changed, 283 insertions(+), 190 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/25/20625/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20625
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib3c3a163186c40a93be0dea666230431172136df
Gerrit-Change-Number: 20625
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201015/8550818e/attachment.htm>