This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
srs_andre gerrit-no-reply at lists.osmocom.orgsrs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20521 ) Change subject: 4g: Introduce ZMQ GnuRadio stream broker ...................................................................... Patch Set 3: Code-Review-1 (4 comments) Very good work. This worked out of the box for me in our setup. There are a few minor suggestions from my side. Please have a look. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20521/3/src/osmo_gsm_tester/obj/rfemu_gnuradio_zmq.py File src/osmo_gsm_tester/obj/rfemu_gnuradio_zmq.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20521/3/src/osmo_gsm_tester/obj/rfemu_gnuradio_zmq.py@192 PS3, Line 192: self.broker.cmd_set_relative_gain_on_local_port(cell['zmq_enb_peer_port'], (max_att_db - db)/max_att_db) i'll provide an update for this calculation https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20521/3/src/osmo_gsm_tester/obj/rfemu_gnuradio_zmq.py@196 PS3, Line 196: return 12 # maximum cell_gain value in srs. Is this correct value? also here https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20521/3/sysmocom/scenarios/mod-enb-cells-2ca.conf File sysmocom/scenarios/mod-enb-cells-2ca.conf: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20521/3/sysmocom/scenarios/mod-enb-cells-2ca.conf@12 PS3, Line 12: dl_earfcn: 2850 this causes conflicts with my recent update, but we need to add a new scenario anyway https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20521/3/utils/bin/osmo-gsm-tester_zmq_broker.py File utils/bin/osmo-gsm-tester_zmq_broker.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20521/3/utils/bin/osmo-gsm-tester_zmq_broker.py@19 PS3, Line 19: class GrBroker(gr.top_block): this script works well, however, I am a bit worried about the current file location though. I expect to have at least two or three broker scripts in the future, if no more. Would it be possible to move it to the scenario folder so customization are possible? -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6282cda400558dcb356276786d91e6388524c5b1 Gerrit-Change-Number: 20521 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com> Gerrit-Comment-Date: Wed, 14 Oct 2020 13:52:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201014/fe2983b7/attachment.htm>