This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20630 ) Change subject: LCS: disable Lb interface by default, add vty 'smlc' / 'enable' ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/20630/1/src/osmo-bsc/lb.c File src/osmo-bsc/lb.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20630/1/src/osmo-bsc/lb.c@378 PS1, Line 378: return -EAGAIN; EAGAIN? it's already started, this error code looks more like suggesting the opposite. https://gerrit.osmocom.org/c/osmo-bsc/+/20630/1/src/osmo-bsc/lb.c@616 PS1, Line 616: /* Nothing to write? */ As a side note, I see bsc_gsmnet->smlc being used tons of times in these functions, since basically slmc is the only object touched. So it'd be clearer storing it into an slmc local variable to shorten and make clearer the code. And btw, I find it a bit strange that this stuff is not placed into an lb_vty.c file as we usually do. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I01314a29a2cad6f325d9f4687a9dedca6b90a3ce Gerrit-Change-Number: 20630 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 13 Oct 2020 09:59:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201013/7acc66c3/attachment.htm>