This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20620 ) Change subject: as_handover: fix for signalling channel, without MGCP ...................................................................... as_handover: fix for signalling channel, without MGCP Change-Id: I276f82841c07f8a885ee0659002d4a41e5b180e4 --- M bsc/MSC_ConnectionHandler.ttcn 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index 3e58f5a..5460e2c 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -1323,9 +1323,11 @@ * time. When we receive the RSL_RF_CHAN_REL command the media negotiation on * IPACC or MGCP level may be still in progress. In order to make sure that * we do only stop when we have seen an MDCX on MGCP level and another a CRCX - * as well as an MDCX on IPACC level. */ - if (g_media.mgcp_conn[0].mdcx_seen <= st.mdcx_seen_before_ho or - g_media.bts1.ipa_mdcx_seen == false or g_media.bts1.ipa_crcx_seen == false) { + * as well as an MDCX on IPACC level. + * If ipa_crcx_seen is false, this is not a voice channel and we need not check MGCP at all.. */ + if (g_media.bts.ipa_crcx_seen + and (g_media.mgcp_conn[0].mdcx_seen <= st.mdcx_seen_before_ho or + g_media.bts1.ipa_mdcx_seen == false or g_media.bts1.ipa_crcx_seen == false)) { repeat; } else { st.handover_done := true; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I276f82841c07f8a885ee0659002d4a41e5b180e4 Gerrit-Change-Number: 20620 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201013/3d01ec08/attachment.htm>