This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20629 ) Change subject: BSSMAP RESET: also accept conn cfm events during ST_DISC ...................................................................... BSSMAP RESET: also accept conn cfm events during ST_DISC We don't really expect connection attempts during ST_DISC, but if the user happens to dispatch those events for whatever obscure reasons, treat them instead of erroring about an unallowed event. Change-Id: Ic7c60a40ff25ae647ee659259dfea769bc4592e4 --- M src/osmo-bsc/reset.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/20629/1 diff --git a/src/osmo-bsc/reset.c b/src/osmo-bsc/reset.c index b3f0f69..99a3821 100644 --- a/src/osmo-bsc/reset.c +++ b/src/osmo-bsc/reset.c @@ -118,6 +118,17 @@ reset_fsm_state_chg(fi, RESET_ST_CONN); break; + case RESET_EV_CONN_CFM_FAILURE: + /* ignore */ + break; + + case RESET_EV_CONN_CFM_SUCCESS: + /* A connection succeeded before we managed to do a RESET handshake? + * Then the calling code is not taking care to check reset_is_conn_ready(). + */ + LOGPFSML(fi, LOGL_ERROR, "Connection success confirmed, but we have not seen a RESET-ACK; bug?\n"); + break; + default: OSMO_ASSERT(false); } @@ -183,6 +194,8 @@ .in_event_mask = 0 | S(RESET_EV_RX_RESET) | S(RESET_EV_RX_RESET_ACK) + | S(RESET_EV_CONN_CFM_FAILURE) + | S(RESET_EV_CONN_CFM_SUCCESS) , .out_state_mask = 0 | S(RESET_ST_DISC) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic7c60a40ff25ae647ee659259dfea769bc4592e4 Gerrit-Change-Number: 20629 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/74b3da2d/attachment.htm>