This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20575 ) Change subject: vty: Set TCP_NODELAY on VTY sockets ...................................................................... Patch Set 1: close() should not affect unacknoledged data, it will still be sent afterwards (the socket object is simply moved into another state), but I bet the close() path is not followed whenever a process is killed due to a sigsegfault, since in that case the stream is broken unexpectedly, so it makes no sense to keep sending data (unless the process has already asked previously to close() the socket), and as a result some data may be lost and never sent over the network. I agree though that it's really specific scenarios and I realized after your comments that indeed we sometimes send bulk data over VTY too, so I don't have an strong opinion on merging or abandoning this patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I34f8d3ac70045e48613f67e3c79c2ff49c4d2794 Gerrit-Change-Number: 20575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 12 Oct 2020 16:20:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/f65baead/attachment.htm>