Change in libosmocore[master]: gad.c: try to workaround warning for "h.type >= 0"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon Oct 12 15:50:08 UTC 2020


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/20581 )


Change subject: gad.c: try to workaround warning for "h.type >= 0"
......................................................................

gad.c: try to workaround warning for "h.type >= 0"

The DEC_ERR() macro has a check for a missing type, but when used on the uint
h.type variable, emits a warning about an always-true statement. Try to work
around that warning with a cast to (int).

Related: CID#214888 CID#214890 CID#214891
Change-Id: Ic5fa87d23a6f0ce872de9c1dcfe36023981f70de
---
M src/gsm/gad.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/20581/1

diff --git a/src/gsm/gad.c b/src/gsm/gad.c
index 3ec28f9..f7ee48a 100644
--- a/src/gsm/gad.c
+++ b/src/gsm/gad.c
@@ -252,8 +252,8 @@
 				.rc = (RC), \
 				.type = (TYPE), \
 				.logmsg = talloc_asprintf(*err, "Error decoding GAD%s%s: " fmt, \
-							  (TYPE) >= 0 ? " " : "", \
-							  (TYPE) >= 0 ? osmo_gad_type_name(TYPE) : "", ##args), \
+							  ((int)(TYPE)) >= 0 ? " " : "", \
+							  ((int)(TYPE)) >= 0 ? osmo_gad_type_name(TYPE) : "", ##args), \
 			}; \
 		} \
 		return RC; \

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20581
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic5fa87d23a6f0ce872de9c1dcfe36023981f70de
Gerrit-Change-Number: 20581
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/c431bdae/attachment.htm>


More information about the gerrit-log mailing list