Change in libosmocore[master]: vty: Set TCP_NODELAY on VTY sockets

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Oct 12 15:09:01 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20575 )

Change subject: vty: Set TCP_NODELAY on VTY sockets
......................................................................


Patch Set 1: Code-Review-1

well, interactive, character based applications like telnet are the primary use case for NAGLE.  If we are in a "show" command, printing dozens to hundreds of lines via vty_out(), we certainly want those lines to be aggregared into larger TCP segments, as opposed to sendign one TCP packet every line.

So unless I'm missing something, we should definitely have NAGLE for VTY.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20575
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I34f8d3ac70045e48613f67e3c79c2ff49c4d2794
Gerrit-Change-Number: 20575
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 12 Oct 2020 15:09:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/71722241/attachment.htm>


More information about the gerrit-log mailing list