Change in osmo-ttcn3-hacks[master]: bts: Make f_power_from_band() fail in case of unknown band

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Oct 12 13:12:27 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20547 )

Change subject: bts: Make f_power_from_band() fail in case of unknown band
......................................................................

bts: Make f_power_from_band() fail in case of unknown band

Otherwise we get into weird error cases about unbound variables that are hard to debug.

Change-Id: I5716a5dc6ce95daa663be87a1a4fe611b719495e
---
M bts/BTS_Tests.ttcn
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index bdd8546..c26afcc 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -2824,6 +2824,9 @@
 		min_dbm_level := {15};
 		max_dbm_level := {30};
 	}
+	case else {
+		Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unsupported band: " & band);
+	}
 	}
 
 	return rv;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20547
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5716a5dc6ce95daa663be87a1a4fe611b719495e
Gerrit-Change-Number: 20547
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/2a1f0885/attachment.htm>


More information about the gerrit-log mailing list