Change in osmo-pcu[master]: Rework NS configuration over the info indication

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20565 )

Change subject: Rework NS configuration over the info indication
......................................................................


Patch Set 1:

(7 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/20565/1/src/gprs_bssgp_pcu.cpp 
File src/gprs_bssgp_pcu.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/20565/1/src/gprs_bssgp_pcu.cpp@928 
PS1, Line 928: 			  int valid)
it's a bitmask right? rather use unsigned then, and probably better of fixed length.


https://gerrit.osmocom.org/c/osmo-pcu/+/20565/1/src/gprs_bssgp_pcu.cpp@931 
PS1, Line 931: 	int binds = 0, nsvcs = 0;
same, bitmask.


https://gerrit.osmocom.org/c/osmo-pcu/+/20565/1/src/gprs_bssgp_pcu.cpp@938 
PS1, Line 938: 	for (i=0; i < PCU_IF_NUM_NSVC; i++) {
space


https://gerrit.osmocom.org/c/osmo-pcu/+/20565/1/src/gprs_bssgp_pcu.cpp@943 
PS1, Line 943: 		if (rc < 0 && rc != -EBUSY) {
I?m not really liking this no-op silent behavior when -EBUSY is returned. IMHO this code should be the one checking if the binding already exists and attempting to bind or do nothing. It shouldn't be done transparently by the library layer.


https://gerrit.osmocom.org/c/osmo-pcu/+/20565/1/src/gprs_bssgp_pcu.cpp@966 
PS1, Line 966: 	for (i=0; i < PCU_IF_NUM_NSVC; i++) {
space


https://gerrit.osmocom.org/c/osmo-pcu/+/20565/1/src/gprs_bssgp_pcu.cpp@980 
PS1, Line 980: 				nsvcs |= 1 << i;
so no use for this bitmask, simply store a bool


https://gerrit.osmocom.org/c/osmo-pcu/+/20565/1/src/gprs_bssgp_pcu.cpp@1068 
PS1, Line 1068: 		/* we found all our valid nsvcs and might removed all other nsvcs */
might have removed?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20565
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I589ebaa2a2b7de55b7e4e975d8fd6412dd5f214b
Gerrit-Change-Number: 20565
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Oct 2020 10:13:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/a8523d4e/attachment.htm>