Change in osmo-ggsn[master]: Prevent Crash in show pdp-context from vty

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Oct 12 09:59:23 UTC 2020


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/20534 )

Change subject: Prevent Crash in show pdp-context from vty
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ggsn/+/20534/4/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/20534/4/ggsn/ggsn_vty.c@911 
PS4, Line 911: 		if (!gtp_pdp_getimsi(ggsn->gsn, &pdp, imsi, nsapi)) {
> @pespin Isn't this how it's normally done in osmo? Sorry for messy patchset.
If you expect a return code == 0, then it's ok.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/20534
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Ic40429939b185f97c020dd3904e054fe860b91e8
Gerrit-Change-Number: 20534
Gerrit-PatchSet: 4
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Oct 2020 09:59:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/a5317d90/attachment.htm>


More information about the gerrit-log mailing list