Change in libosmocore[master]: gprs_ns2: const the return value of gprs_ns2_ip_vc_sockaddr / gprs_ns...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Mon Oct 12 01:16:51 UTC 2020


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/20557 )


Change subject: gprs_ns2: const the return value of gprs_ns2_ip_vc_sockaddr / gprs_ns2_ip_bind_sockaddr
......................................................................

gprs_ns2: const the return value of gprs_ns2_ip_vc_sockaddr / gprs_ns2_ip_bind_sockaddr

The sockaddr should not be changed.
free and create the bind/nsvc if the address should be changed.

Change-Id: I371ac2361b569e36722b02fc9cd82ec8da2fa9e3
---
M include/osmocom/gprs/gprs_ns2.h
M src/gb/gprs_ns2.c
M src/gb/gprs_ns2_sns.c
M src/gb/gprs_ns2_udp.c
M src/gb/gprs_ns2_vty.c
5 files changed, 14 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/57/20557/1

diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h
index 7531530..a3edc63 100644
--- a/include/osmocom/gprs/gprs_ns2.h
+++ b/include/osmocom/gprs/gprs_ns2.h
@@ -139,8 +139,8 @@
 			    const struct osmo_sockaddr *remote,
 			    uint16_t nsei);
 
-struct osmo_sockaddr *gprs_ns2_ip_vc_sockaddr(struct gprs_ns2_vc *nsvc);
-struct osmo_sockaddr *gprs_ns2_ip_bind_sockaddr(struct gprs_ns2_vc_bind *bind);
+const struct osmo_sockaddr *gprs_ns2_ip_vc_sockaddr(struct gprs_ns2_vc *nsvc);
+const struct osmo_sockaddr *gprs_ns2_ip_bind_sockaddr(struct gprs_ns2_vc_bind *bind);
 int gprs_ns2_is_ip_bind(struct gprs_ns2_vc_bind *bind);
 int gprs_ns2_ip_bind_set_dscp(struct gprs_ns2_vc_bind *bind, int dscp);
 struct gprs_ns2_vc *gprs_ns2_nsvc_by_sockaddr_bind(
diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c
index a476cff..4f9c5ac 100644
--- a/src/gb/gprs_ns2.c
+++ b/src/gb/gprs_ns2.c
@@ -210,8 +210,8 @@
  *  \return pointer to buf on success; NULL on error */
 char *gprs_ns2_ll_str_buf(char *buf, size_t buf_len, struct gprs_ns2_vc *nsvc)
 {
-	struct osmo_sockaddr *local;
-	struct osmo_sockaddr *remote;
+	const struct osmo_sockaddr *local;
+	const struct osmo_sockaddr *remote;
 	struct osmo_sockaddr_str local_str;
 	struct osmo_sockaddr_str remote_str;
 
@@ -847,7 +847,7 @@
 						  const struct osmo_sockaddr *sockaddr)
 {
 	struct gprs_ns2_vc *nsvc;
-	struct osmo_sockaddr *remote;
+	const struct osmo_sockaddr *remote;
 
 	OSMO_ASSERT(nse);
 	OSMO_ASSERT(sockaddr);
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index ec6f31f..b476b46 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -473,7 +473,7 @@
 	struct gprs_ns2_nse *nse = nse_inst_from_fi(fi);
 	struct gprs_ns2_vc *nsvc;
 	struct osmo_sockaddr sa = {};
-	struct osmo_sockaddr *remote;
+	const struct osmo_sockaddr *remote;
 	uint8_t new_signal;
 	uint8_t new_data;
 
@@ -533,7 +533,7 @@
 	struct ns2_sns_state *gss = (struct ns2_sns_state *) fi->priv;
 	struct gprs_ns2_nse *nse = nse_inst_from_fi(fi);
 	struct gprs_ns2_vc *nsvc, *tmp;
-	struct osmo_sockaddr *remote;
+	const struct osmo_sockaddr *remote;
 	struct osmo_sockaddr sa = {};
 
 	if (ip4) {
@@ -1239,7 +1239,9 @@
 	struct gprs_ns_ie_ip6_elem *ip6_elems;
 	struct gprs_ns2_vc_bind *bind;
 	struct gprs_ns2_inst *nsi = nse->nsi;
-	struct osmo_sockaddr *sa, local;
+	const struct osmo_sockaddr *sa;
+	struct osmo_sockaddr local;
+
 	gss->ip = remote->u.sa.sa_family == AF_INET ? IPv4 : IPv6;
 
 	gss->initial = *remote;
diff --git a/src/gb/gprs_ns2_udp.c b/src/gb/gprs_ns2_udp.c
index 7ead71a..9aca80b 100644
--- a/src/gb/gprs_ns2_udp.c
+++ b/src/gb/gprs_ns2_udp.c
@@ -274,7 +274,7 @@
 						      const struct osmo_sockaddr *sockaddr)
 {
 	struct gprs_ns2_vc_bind *bind;
-	struct osmo_sockaddr *local;
+	const struct osmo_sockaddr *local;
 
 	OSMO_ASSERT(nsi);
 	OSMO_ASSERT(sockaddr);
@@ -396,7 +396,7 @@
 /*! Return the socket address of the remote peer of a NS-VC.
  *  \param[in] nsvc NS-VC whose remote peer we want to know
  *  \return address of the remote peer; NULL in case of error */
-struct osmo_sockaddr *gprs_ns2_ip_vc_sockaddr(struct gprs_ns2_vc *nsvc)
+const struct osmo_sockaddr *gprs_ns2_ip_vc_sockaddr(struct gprs_ns2_vc *nsvc)
 {
 	struct priv_vc *priv;
 
@@ -410,7 +410,7 @@
 /*! Return the locally bound socket address of the bind.
  *  \param[in] bind The bind whose local address we want to know
  *  \return address of the local bind */
-struct osmo_sockaddr *gprs_ns2_ip_bind_sockaddr(struct gprs_ns2_vc_bind *bind)
+const struct osmo_sockaddr *gprs_ns2_ip_bind_sockaddr(struct gprs_ns2_vc_bind *bind)
 {
 	struct priv_bind *priv;
 
diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c
index 55e87ae..92c0095 100644
--- a/src/gb/gprs_ns2_vty.c
+++ b/src/gb/gprs_ns2_vty.c
@@ -247,7 +247,7 @@
 {
 	struct osmo_sockaddr_str remote;
 	struct osmo_sockaddr_str local;
-	struct osmo_sockaddr *sockaddr;
+	const struct osmo_sockaddr *sockaddr;
 
 	switch (nsvc->ll) {
 	case GPRS_NS_LL_UDP: {

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20557
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I371ac2361b569e36722b02fc9cd82ec8da2fa9e3
Gerrit-Change-Number: 20557
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/7e0febdf/attachment.htm>


More information about the gerrit-log mailing list