This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/20532 ) Change subject: Fix vty PDP lookups by IMSI ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/7/ggsn/ggsn_vty.c File ggsn/ggsn_vty.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/7/ggsn/ggsn_vty.c@912 PS7, Line 912: imsi |= ((uint64_t) (argv[1][i] - 48)) << (i * 4); where does this 48 come from? 'A'? Then use 'A'. And please indeed move this to a function as you mention in the comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/20532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Icd2e2bc6068c06fbf5d5fe905ebcda8954f33f04 Gerrit-Change-Number: 20532 Gerrit-PatchSet: 7 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-Reviewer: keith <keith at rhizomatica.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sun, 11 Oct 2020 22:02:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201011/c40e4f69/attachment.htm>