This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20539 ) Change subject: bts: Avoid race condition in TC_pcu_deact_req ...................................................................... bts: Avoid race condition in TC_pcu_deact_req When our emulated PCU sends a DEACT.req to the BTS, there is no way of knowing when exactly that command will have been completed: There is no confirmation sent in response. Let's introduce a f_sleep(1.0) to give the BTS sufficient time for deactivating the channel. This will make TC_pcu_deact_req pass reliably. It currently fails in about one third of all test executions on jenkins. Change-Id: Id9a559b8b208a60f71c3eb9a23830e4d2dbc5df9 --- M bts/BTS_Tests.ttcn 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/39/20539/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 221c33e..95d0dab 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -4364,7 +4364,9 @@ /* Send PDCH activate request for known PDCH timeslot */ PCU.send(t_SD_PCUIF(g_pcu_conn_id, ts_PCUIF_DEACT_REQ(bts_nr, trx_nr, ts_nr))); - + /* wait for some time as there is no PCUIF_DEACT_RESP or the like, so we don't know + * when it will actually have been executed in the BTS */ + f_sleep(1.0); PCU.clear; /* we now expect no RTS.req for this timeslot */ T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9a559b8b208a60f71c3eb9a23830e4d2dbc5df9 Gerrit-Change-Number: 20539 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201011/b2040e0e/attachment.htm>