This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/20532 ) Change subject: Fix vty PDP lookups by IMSI ...................................................................... Patch Set 4: (6 comments) https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/4/ggsn/ggsn_vty.c File ggsn/ggsn_vty.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/4/ggsn/ggsn_vty.c@902 PS4, Line 902: //imsi = strtoull(argv[1], NULL, 10); This should be removed. https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/4/ggsn/ggsn_vty.c@936 PS4, Line 936: // Please use /* ... */ instead. https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/4/ggsn/ggsn_vty.c@937 PS4, Line 937: 0 ... so then we should compare to EOF here? https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/4/ggsn/ggsn_vty.c@943 PS4, Line 943: // Please use /* ... */ instead. https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/4/gtp/pdp.c File gtp/pdp.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/4/gtp/pdp.c@277 PS4, Line 277: hash This looks like an unrelated change (logging improvement). https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/4/gtp/pdp.c@322 PS4, Line 322: hash This looks like an unrelated change (logging improvement). -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/20532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Icd2e2bc6068c06fbf5d5fe905ebcda8954f33f04 Gerrit-Change-Number: 20532 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith at rhizomatica.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Sat, 10 Oct 2020 13:21:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201010/77abad05/attachment.htm>