Change in osmo-pcu[master]: gprs_bssgp_pcu: fix: do not crash on receipt of subsequent INFO.ind

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat Oct 10 13:11:26 UTC 2020


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20530 )

Change subject: gprs_bssgp_pcu: fix: do not crash on receipt of subsequent INFO.ind
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> We should track the NSVC/NSEI configuration and if they changed we should detroy and reinstantiate the nsi.

We definitely must not destroy and re-init it unconditionally. Is there API for checking if the NSVC/NSEI configuration received on the PCUIF differs? If yes, we should start using it here. If no, let's merge this change ASAP, because it degrades not only PS, but also CS service (dynamic timeslots).


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20530
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I159138e41e147cd30212da548b0ccd3f81d61b4e
Gerrit-Change-Number: 20530
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 10 Oct 2020 13:11:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201010/e2b85bb3/attachment.htm>


More information about the gerrit-log mailing list