This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20529 ) Change subject: struct gprs_rlcmac_bts: remove unused 'nsei' field ...................................................................... struct gprs_rlcmac_bts: remove unused 'nsei' field The code in gprs_nsvc_create_and_connect() stores NSEI there for no reason, despite it's already stored in struct gprs_ns2_nse. Change-Id: Ib30152a12384cf0448104a1ee1cfb949f4a27553 --- M src/bts.h M src/gprs_bssgp_pcu.cpp 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts.h b/src/bts.h index e930463..4340199 100644 --- a/src/bts.h +++ b/src/bts.h @@ -178,7 +178,6 @@ struct gprs_ns2_inst *nsi; /* main nsei */ struct gprs_ns2_nse *nse; - uint16_t nsei; }; enum { diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index 143d4dc..e0cfc37 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -947,7 +947,6 @@ return 1; } - bts->nsei = nsei; if (bts->gb_dialect_sns) { rc = gprs_ns2_ip_connect_sns(bind, sgsn, nsei); } else { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib30152a12384cf0448104a1ee1cfb949f4a27553 Gerrit-Change-Number: 20529 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201010/7472132f/attachment.htm>