Change in libosmocore[master]: gprs_ns2: make struct osmo_sockaddr pointers const

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Oct 9 15:09:24 UTC 2020


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20511 )

Change subject: gprs_ns2: make struct osmo_sockaddr pointers const
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/20511/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/20511/1//COMMIT_MSG@11 
PS1, Line 11: the author(s) of the new NS2 library are not aware about that.
> Drop last line, since that's a totally not required speculation and provides no benefit. […]
Done. I still think that it's bad to introduce new code that makes no use of 'const' where appropriate, because the code that follows this rule would not compile due to:

  error: invalid conversion from ‘const osmo_sockaddr*’ to ‘osmo_sockaddr*’ [-fpermissive]

so others need to revisit the API and correct it. Didn't mean to offend anybody.

We should also be more strict when doing code review and should not disregard the benefits and importance of 'const'.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20511
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0df6a00ac1830bd64a10b9336b827e113fa772bb
Gerrit-Change-Number: 20511
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Oct 2020 15:09:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201009/1346968a/attachment.htm>


More information about the gerrit-log mailing list