Change in osmo-bts[master]: pcu_sock: use llist_for_each_entry() in pcu_sock_close()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20493 )

Change subject: pcu_sock: use llist_for_each_entry() in pcu_sock_close()
......................................................................

pcu_sock: use llist_for_each_entry() in pcu_sock_close()

Using gsm_bts_trx_num() involves redundant iterations over the
list of transceivers - we definitely don't want them.

Change-Id: I4bd40ffcc1e925412a21b0a934bbfdeddbc6ad1f
---
M src/common/pcu_sock.c
1 file changed, 5 insertions(+), 8 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 7f7f7cf..d54e385 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -883,7 +883,7 @@
 	struct gsm_bts *bts;
 	struct gsm_bts_trx *trx;
 	struct gsm_bts_trx_ts *ts;
-	int i, j;
+	unsigned int tn;
 
 	/* FIXME: allow multiple BTS */
 	bts = llist_entry(state->net->bts_list.next, struct gsm_bts, list);
@@ -910,13 +910,10 @@
 	osmo_signal_dispatch(SS_GLOBAL, S_NEW_SYSINFO, bts);
 #endif
 
-	/* release PDCH */
-	for (i = 0; i < 8; i++) {
-		trx = gsm_bts_trx_num(bts, i);
-		if (!trx)
-			break;
-		for (j = 0; j < 8; j++) {
-			ts = &trx->ts[j];
+	/* Deactivate all active PDCH timeslots */
+	llist_for_each_entry(trx, &bts->trx_list, list) {
+		for (tn = 0; tn < 8; tn++) {
+			ts = &trx->ts[tn];
 			if (ts->mo.nm_state.operational == NM_OPSTATE_ENABLED
 			 && ts->pchan == GSM_PCHAN_PDCH) {
 				ts->lchan[0].rel_act_kind = LCHAN_REL_ACT_PCU;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20493
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4bd40ffcc1e925412a21b0a934bbfdeddbc6ad1f
Gerrit-Change-Number: 20493
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201008/cb9152e7/attachment.htm>