Change in libosmocore[master]: command: add library command attribute for libosmo-abis

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Oct 8 19:58:16 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20481 )

Change subject: command: add library command attribute for libosmo-abis
......................................................................

command: add library command attribute for libosmo-abis

Change-Id: I0efc57f2cb54798ba207ae6fef9af4771d96bfa9
Related: SYS#4937, OS#1601
---
M include/osmocom/vty/command.h
M src/vty/command.c
M tests/vty/vty_transcript_test.vty
3 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, approved



diff --git a/include/osmocom/vty/command.h b/include/osmocom/vty/command.h
index 232da2c..2cb45dd 100644
--- a/include/osmocom/vty/command.h
+++ b/include/osmocom/vty/command.h
@@ -153,6 +153,8 @@
 	 * 3. Values are not flags but indexes, unlike CMD_ATTR_*.
 	 * 4. Ordering: new entries added before _OSMO_CORE_LIB_ATTR_COUNT. */
 	OSMO_SCCP_LIB_ATTR_RSTRT_ASP,
+	OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK,
+	OSMO_ABIS_LIB_ATTR_LINE_UPD,
 
 	/* Keep this floating entry last, it's needed for count check. */
 	_OSMO_CORE_LIB_ATTR_COUNT
diff --git a/src/vty/command.c b/src/vty/command.c
index 4952567..fae925e 100644
--- a/src/vty/command.c
+++ b/src/vty/command.c
@@ -654,6 +654,10 @@
 	 * 	"Brief but meaningful description", */
 	[OSMO_SCCP_LIB_ATTR_RSTRT_ASP] = \
 		"This command applies on ASP restart",
+	[OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK] = \
+		"This command applies on IPA link establishment",
+	[OSMO_ABIS_LIB_ATTR_LINE_UPD] = \
+		"This command applies on E1 line update",
 };
 
 /* Flag letters of attributes shared between the lib commands.
@@ -661,6 +665,8 @@
 static const char cmd_lib_attr_letters[32] = {
 	/* [OSMO_LIBNAME_LIB_ATTR_ATTRNAME] =		'X', */
 	[OSMO_SCCP_LIB_ATTR_RSTRT_ASP] =		'A',
+	[OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK] =		'I',
+	[OSMO_ABIS_LIB_ATTR_LINE_UPD] =			'L',
 };
 
 /*
diff --git a/tests/vty/vty_transcript_test.vty b/tests/vty/vty_transcript_test.vty
index b626f3d..2c618d8 100644
--- a/tests/vty/vty_transcript_test.vty
+++ b/tests/vty/vty_transcript_test.vty
@@ -91,6 +91,8 @@
     @  This command applies on VTY node exit
   Library specific attributes:
     A  This command applies on ASP restart
+    I  This command applies on IPA link establishment
+    L  This command applies on E1 line update
   Application specific attributes:
     u  Unbelievable: not able to be believed; unlikely to be true
     m  Magnificent: impressively beautiful, elaborate, or extravagant

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20481
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0efc57f2cb54798ba207ae6fef9af4771d96bfa9
Gerrit-Change-Number: 20481
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201008/3c2f7acd/attachment.htm>


More information about the gerrit-log mailing list