Change in osmo-bsc[master]: gsm_08_08: fix unreachable code in parse_powercap()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Oct 8 19:21:51 UTC 2020


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20496 )


Change subject: gsm_08_08: fix unreachable code in parse_powercap()
......................................................................

gsm_08_08: fix unreachable code in parse_powercap()

The function parse_powercap() contains a nested switch case statement
that is used to populate the variables lu and pwr_lev. Those variables
are used at the bottom of the function later. Unfortunately the (outer)
switch case that consumes the pdisc variable does not put a break; at
the end of its only case "GSM48_PDISC_MM", which eventually causes a
fall through to the default case, which simply returns. Since this can
not be intended, lets add a break to make the bottom code reachable in
case lu and pwr_lev are successfully populated.

Change-Id: I48331cca784d8fa3a5904f2c4cf1555622b319e8
Fixes: CID#214886
---
M src/osmo-bsc/gsm_08_08.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/96/20496/1

diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index f3214c7..b7c7448 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -343,6 +343,7 @@
 			/* No power cap in other messages */
 			return;
 		}
+		break;
 	/* FIXME: pwr_lev in Paging Response? */
 	default:
 		/* No power cap in other messages */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20496
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I48331cca784d8fa3a5904f2c4cf1555622b319e8
Gerrit-Change-Number: 20496
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201008/95fff9b8/attachment.htm>


More information about the gerrit-log mailing list