This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/20495 ) Change subject: oml: fix handling of NSVC local port in oml_ipa_mo_set_attr_nsvc() ...................................................................... oml: fix handling of NSVC local port in oml_ipa_mo_set_attr_nsvc() This is another regresion introduced by [1]. Both local and remote port numbers recived in the network order, and must be stored as-is. Change-Id: I3c21a2c27dcbf6de728ce2c7ccbae9e2f517c450 Fixes: I310699fabbfec4255f0474f31717f215c1201eca Related: SYS#4915 --- M src/common/oml.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/95/20495/1 diff --git a/src/common/oml.c b/src/common/oml.c index 5394e8a..2a87b03 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -1272,7 +1272,7 @@ nsvc->remote.u.sin.sin_addr.s_addr = _cur_l; cur += 4; memcpy(&_cur_s, cur, 2); - nsvc->local.u.sin.sin_port = ntohs(_cur_s); + nsvc->local.u.sin.sin_port = _cur_s; } if (TLVP_PRES_LEN(tp, NM_ATT_OSMO_NS_LINK_CFG, 10)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3c21a2c27dcbf6de728ce2c7ccbae9e2f517c450 Gerrit-Change-Number: 20495 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201008/76f0916c/attachment.htm>