Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix f_mo_l3_transceive(): relax DLCI matching

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Oct 8 16:54:06 UTC 2020


Vadim Yanitskiy has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20490 )

Change subject: BSC_Tests: fix f_mo_l3_transceive(): relax DLCI matching
......................................................................

BSC_Tests: fix f_mo_l3_transceive(): relax DLCI matching

Since If4d479a54cad467f53b49065c1c435a4471ac7d2, osmo-bsc started
to send more concrete DLCI values on the A/BSSAP interface.  In
particular, the control channel identification bits now indicate
whether it's SDCCH/FACCH or SACCH channel.

Let's use '?' as the default DLCI template that we expect to get
from the IUT, so those test cases, for which DLCI is not a part
of the testing scenario, would not fail.

Change-Id: Ida659d53e0d31f9aa0ea2ccccefc94d8c659eb76
---
M bsc/BSC_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  neels: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 20fcf36..b141a0a 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -4521,7 +4521,7 @@
 }
 
 private function f_mo_l3_transceive(template (value) RslLinkId link_id := ts_RslLinkID_DCCH(0),
-				    template (present) OCT1 dlci := '00'O,
+				    template (present) OCT1 dlci := ?,
 				    octetstring l3 := '0123456789'O)
 runs on MSC_ConnHdlr {
 	/* The old lchan and conn should still be active. See that arbitrary L3

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20490
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ida659d53e0d31f9aa0ea2ccccefc94d8c659eb76
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201008/130e2d65/attachment.htm>


More information about the gerrit-log mailing list