This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20333 ) Change subject: add BSSLAP coding for Location Services ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/20333/4/src/gsm/bsslap.c File src/gsm/bsslap.c: https://gerrit.osmocom.org/c/libosmocore/+/20333/4/src/gsm/bsslap.c@73 PS4, Line 73: err_ctx > not particularly happy that we have a macro making assumptions about variable names in its context, […] i'd never do that in a .h file... there's always exactly one 'err' and 'err_ctx' in every IE decoding scope in this .c file, that's why I allowed myself to not pass it explicitly. https://gerrit.osmocom.org/c/libosmocore/+/20333/4/src/gsm/bsslap.c@217 PS4, Line 217: void *err_ctx > I would have avoided the extra argument and allocated from one of our OTC_SELECT or te like talloc c […] I would have *liked* to always use OTC_SELECT, but that would make assumptions on the caller using osmo_select_main_ctx(), and maybe someone would like the error message to survive as long as the msgb that caused it? I would be very happy to strip this argument, but currently I don't see how we can? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6409c4bcac402dc7626a3afce9081c59cd715fe8 Gerrit-Change-Number: 20333 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 07 Oct 2020 12:46:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201007/741c3bd9/attachment.htm>