This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20332 )
Change subject: add GAD coding for Location Services
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c
File src/gsm/gad.c:
https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c@250
PS1, Line 250: *gad = (struct osmo_gad){};
> What I don't want for sure is spending time myself fixing another test which uses memcmp() being ini […]
the current patch version still uses memcmp to compare structs in gad_test.c ... because it's either that, or writing a full osmo_gad_cmp() function doing a "manual" == on each and every union and struct member, which is hrrggn. Maybe we could write some script that writes that for us and replace all existing memcmp()s we have around with that.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20332
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7a9dd805a91b1ebb6353bde0cd169218acbf223c
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Oct 2020 12:41:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201007/7504513b/attachment.htm>