Change in osmo-bsc[master]: gscon_bssmap_clear(): guard against NULL msc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Wed Oct 7 12:23:11 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20339 )

Change subject: gscon_bssmap_clear(): guard against NULL msc
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/20339/1/src/osmo-bsc/bsc_subscr_conn_fsm.c 
File src/osmo-bsc/bsc_subscr_conn_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20339/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@153 
PS1, Line 153: return
> ... […]
no because resp == NULL


https://gerrit.osmocom.org/c/osmo-bsc/+/20339/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@158 
PS1, Line 158: return
> and here? I would rather move this check upwards, because it does not make sense to allocate msgb if […]
yes



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20339
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I95b16cebb6ff78649f72a09b5d6c7c7e403233fa
Gerrit-Change-Number: 20339
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Oct 2020 12:23:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201007/3b513c65/attachment.htm>


More information about the gerrit-log mailing list