This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20333 ) Change subject: add BSSLAP coding for Location Services ...................................................................... Patch Set 4: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/20333/4/src/gsm/bsslap.c File src/gsm/bsslap.c: https://gerrit.osmocom.org/c/libosmocore/+/20333/4/src/gsm/bsslap.c@73 PS4, Line 73: err_ctx not particularly happy that we have a macro making assumptions about variable names in its context, but this is not critical. vty_out() is setting a bad example (But we didn't write it). https://gerrit.osmocom.org/c/libosmocore/+/20333/4/src/gsm/bsslap.c@217 PS4, Line 217: void *err_ctx I would have avoided the extra argument and allocated from one of our OTC_SELECT or te like talloc contexts. But not critical, no need to change. In the end, it's unlikely that the error would need to survive the current select / message processing context, so I think it would be a good fit. And reducing argument count of functions is always good, makes them simpler to use. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6409c4bcac402dc7626a3afce9081c59cd715fe8 Gerrit-Change-Number: 20333 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 07 Oct 2020 10:13:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201007/7e3c3d40/attachment.htm>