This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20271 ) Change subject: Use the new NS2 lib ...................................................................... Patch Set 7: (5 comments) Mostly cosmetic comments, nothing critical. https://gerrit.osmocom.org/c/osmo-pcu/+/20271/7/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/20271/7/src/gprs_bssgp_pcu.cpp@578 PS7, Line 578: LOGL_NOTICE looks more like an ERROR? https://gerrit.osmocom.org/c/osmo-pcu/+/20271/7/src/gprs_bssgp_pcu.cpp@598 PS7, Line 598: LOGL_NOTICE ERROR and return a negative errno? https://gerrit.osmocom.org/c/osmo-pcu/+/20271/7/src/gprs_bssgp_pcu.cpp@617 PS7, Line 617: LOGL_NOTICE same here https://gerrit.osmocom.org/c/osmo-pcu/+/20271/7/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/20271/7/src/pcu_l1_if.cpp@578 PS7, Line 578: LOGL_NOTICE This one also looks more like an error. https://gerrit.osmocom.org/c/osmo-pcu/+/20271/7/src/pcu_l1_if.cpp@582 PS7, Line 582: int i=0; i<2; i++) coding style -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib389925cf5c9f18951af6242c31ea70476218e9a Gerrit-Change-Number: 20271 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Assignee: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-CC: daniel <dwillmann at sysmocom.de> Gerrit-Comment-Date: Wed, 07 Oct 2020 10:12:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201007/721c2342/attachment.htm>