Change in osmo-ttcn3-hacks[master]: pcu/GPRS_Components: work around a race condition in f_rx_rlcmac_dl_b...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Oct 6 08:18:47 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20461 )

Change subject: pcu/GPRS_Components: work around a race condition in f_rx_rlcmac_dl_block()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20461/1/pcu/GPRS_Components.ttcn 
File pcu/GPRS_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20461/1/pcu/GPRS_Components.ttcn@687 
PS1, Line 687: 		dl_block := dec_RlcmacDlBlock(pcu_msg.u.data_req.data);
IIRC in some tests we may be explicitly testing to receive a DUMMY packet (for instance because TBF was released or no more data to send, or whatever). Just pointing this out in case those parts are not broken. so it may make sense to have this "if not match DUMMY break" under some boolean parameter allowing DUMMY to be returned.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20461
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8d01e153913a5441113af1866ff2897ee4a987db
Gerrit-Change-Number: 20461
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Oct 2020 08:18:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201006/bd66c963/attachment.htm>


More information about the gerrit-log mailing list