Change in libosmocore[master]: add GAD coding for Location Services

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon Oct 5 19:00:58 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20332 )

Change subject: add GAD coding for Location Services
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c 
File src/gsm/gad.c:

https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c@250 
PS1, Line 250: 	*gad = (struct osmo_gad){};
> >> I think we ha that discussion before, and the language construct neels uses here should be equiva […]
hmm I see that memcmp() is unfortunately not a good choice to compare structs (and I knew that before, but comparing every single element is so dumb, I wish C allowed '==' on structs).

Still I generally want to zero-initialize all struct members, regardless of whether padding is also zeroed or not. I usually choose struct member types such that their zero value represents "not set" / "not initialized" / a sane default value.

The GAD struct does not really need that, and we could discuss that, but it's not like leaving random data in it would improve anything in any noticeable way. So I'd rather not spend time on this aspect.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20332
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7a9dd805a91b1ebb6353bde0cd169218acbf223c
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Oct 2020 19:00:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201005/e3abfc9a/attachment.htm>


More information about the gerrit-log mailing list