Change in osmo-bts[master]: Introduce NM BTS Site Manager FSM

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Oct 5 10:35:08 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20408 )

Change subject: Introduce NM BTS Site Manager FSM
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/nm_bts_sm_fsm.h 
File include/osmo-bts/nm_bts_sm_fsm.h:

https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/nm_bts_sm_fsm.h@40 
PS1, Line 40: nm_bts_sm_fsm
> Why not nm_bts_site_manager?

This looks good too, even better than my proposal. Since this symbol is not going to be used often, I don't think we need to shorten it. I vote for readability in this situation.

> Or xyz? nm_bts_sm_fsm looks good for me.

'xyz' looks like irrelevant irony. I am not trying to throw a stick between your legs, just posting my concerns / ideas, so let's avoid that. 'nm_bts_sm_fsm' may look confusing, because I haven't seen such abbreviation in the specs. (neither in the existing code), and it may be hard to find the relation for other people looking at this code. Moreover, 'SM' usually stands for 'Short Message' in TS 04.11 and the related core network specs. This is why I suggest to rename it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20408
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iab2d17c45c9642860cd2d5d523c1baae24502243
Gerrit-Change-Number: 20408
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 05 Oct 2020 10:35:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201005/5219f64d/attachment.htm>


More information about the gerrit-log mailing list