This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20408 ) Change subject: Introduce NM BTS Site Manager FSM ...................................................................... Patch Set 1: (5 comments) https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/bts.h File include/osmo-bts/bts.h: https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/bts.h@148 PS1, Line 148: /* NM BTS Site Manager FSM */ : struct osmo_fsm_inst *fi; : bool opstart_success; > why don't we move this into the gsm_abis_mo? Shouldn't every one of them have a fsm_inst and some s […] Yes I guess I can move it inside. https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/nm_bts_sm_fsm.h File include/osmo-bts/nm_bts_sm_fsm.h: https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/nm_bts_sm_fsm.h@40 PS1, Line 40: nm_bts_sm_fsm > Why not 'nm_bts_site_mgr_fsm'? Why not nm_bts_site_manager? Or xyz? nm_bts_sm_fsm looks good for me. https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/bts.c File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/bts.c@224 PS1, Line 224: LOGL_INFO, NULL); > alignment Ack https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/bts.c@225 PS1, Line 225: bts_sm%d > fixeria is correct. […] Yes indeed the SiteManager is for all BTS, but since we only support one BTS and the site_mgr struct is inlined inside the gsm_bts one, I simply put it that way. I don't see a big issue with it but I can remove the %d part sure. https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/oml.c@1624 PS1, Line 1624: obj = bts > I am not getting this... Site manager != BTS. Yeah sure, but anyway we don't really have a separate site_mgr struct (it's inlined inside bts) so it was easier to pass arorund the BTS object which contains all the information. I could add a site_mgr->bts backpointer and keep this as site_mgr if you want. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iab2d17c45c9642860cd2d5d523c1baae24502243 Gerrit-Change-Number: 20408 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 05 Oct 2020 09:20:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201005/373b12fc/attachment.htm>