This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20407 )
Change subject: Change NM Channel availability Dependency->Offline when RadioCarrier becomes enabled
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review-1
>
> Ack! Let's avoid code duplication please, we already have a lot of copy-paste in osmo-bts-{sysmo,oct2g,lc12}...
See my comment in osmo-bsc patches. They may look rather similar right now, but they have slight differences in behavior. Also that's because we have really poor implementations right now. These patches aim at adding initial infrastructure to improve and properly handle each object properly in the future (like moving them to Disabled Dependency when we Adminsitratively lock them, to cascade status on the object hierarchy, etc.). So in the end they will end up differing more and more.
So I think trying to put stuff together for different objects is counterproductive mesure in the long run, because we'll end up going the opposite path afterwards. Let's rather keep differentiated FSMs in the common/ dir and try to squeeze as much as possible repeated code in per-device code (and that can be done further in patches after these ones once further clean up is done).
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20407
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id9e61f8d773e6e6170c68b5b836d276c747d8d69
Gerrit-Change-Number: 20407
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 05 Oct 2020 09:11:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201005/fc055f26/attachment.htm>