Change in osmo-bsc[master]: Introduce NM BTS Site Manager FSM

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Oct 5 09:04:32 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20400 )

Change subject: Introduce NM BTS Site Manager FSM
......................................................................


Patch Set 3:

I didn't know about abis_om2000.c before, I had a look now. I also thought about having a shared FSM for different objects, but in the end I decided to go to one different FSM per NM object since in the long term I think it makes sense to control them differently because different actions need to be taken (and different specific workarounds need to be applied on different objects depending on which type of peer are we talking too). I think this difference will become more evident as we start adding more fine control and features to each object.

This current implementation is not aiming to be the last ultimate implementation for these objects, but I think it's a pretty good one to start with and improve iteratively from. I'm open to changing stuff but I think it makes sense to have it merged without major changes and then start doing improvements on top of that, since I have spent already quite a lot of time on it and I also need to move on to other stuff which also requires my attention, and this implementation already solves some of the issues I spotted and/or provides means to fix them quickly, which means we avoid having currently broken setups (like sysmobts or previously some osmo-bts-trx ones).


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20400
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic001ce6ebeff6f51470ef58140b0235f4a30265e
Gerrit-Change-Number: 20400
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 05 Oct 2020 09:04:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201005/93f48287/attachment.htm>


More information about the gerrit-log mailing list