This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20414 ) Change subject: gsm_08_08: cosmetic: avoid confusion between LINKID and DLCI ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/20414/1/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/20414/1/include/osmocom/bsc/gsm_data.h@54 PS1, Line 54: JFYI: I am not the author of this code, and not trying to advocate the current approach. > We should *either* we always store a RSL link ID, *or* we store a DLCI. As far as I understand, this is exactly what we're doing. A given msgb is either an RSL message or a BSSAP message, so we store either RSL Link ID or DLCI respectively. Not both at the same time. The code simply makes use of msgb->cb[3] for both identifiers. I agree that the macro name is confusing, and I guess this lead to direct RSL Link ID / DLCI assignment bugs. This is why I introduced an alias. Of course, we can use a different location, but what would we benefit? A message cannot be RSL and BSSAP at the same time. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I41e34670a4e173cdbd9617d2c7f7c49b1f5ab46c Gerrit-Change-Number: 20414 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sat, 03 Oct 2020 07:53:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201003/9619b39e/attachment.htm>