Change in osmo-bsc[master]: Introduce NM BTS Site Manager FSM

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20400 )

Change subject: Introduce NM BTS Site Manager FSM
......................................................................


Patch Set 3:

(2 comments)

Did you check the way how MOs and FSMs work in abis_om2000.c? I really like about that code that the MO is turned into a 'first class citizen', and that 'struct om2k_mo' encapsulates all the MO parameters (like its address) and the FSM instance in one.  Also, there's one shared enumeration of externalevents going into those MO.  So all in all, there's more encapsulation which makes the "user" of those FSMs more generic.  Receiving an OML message basically consists only of resolving the MO by its addres, and sending the event related to that OML message to the MO, all in a generic function (abis_om2k_rcvmsg in that case).

https://gerrit.osmocom.org/c/osmo-bsc/+/20400/3/include/osmocom/bsc/bts.h 
File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20400/3/include/osmocom/bsc/bts.h@429 
PS3, Line 429: struct osmo_fsm_inst *fi;
             : 		bool opstart_sent;
see my comment about making those part of the gsm_abis_mo


https://gerrit.osmocom.org/c/osmo-bsc/+/20400/3/include/osmocom/bsc/nm_bts_sm_fsm.h 
File include/osmocom/bsc/nm_bts_sm_fsm.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20400/3/include/osmocom/bsc/nm_bts_sm_fsm.h@36 
PS3, Line 36: NM_BTS_SM_EV_SW_ACT_REP,
            : 	NM_BTS_SM_EV_STATE_CHG_REP,
            : 	NM_BTS_SM_EV_OPSTART_ACK,
            : 	NM_BTS_SM_EV_OPSTART_NACK,
also, those four first events could be common events



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20400
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic001ce6ebeff6f51470ef58140b0235f4a30265e
Gerrit-Change-Number: 20400
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 03 Oct 2020 07:34:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201003/128ec24e/attachment.htm>