This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20408 ) Change subject: Introduce NM BTS Site Manager FSM ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/nm_bts_sm_fsm.h File include/osmo-bts/nm_bts_sm_fsm.h: https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/nm_bts_sm_fsm.h@40 PS1, Line 40: nm_bts_sm_fsm Why not 'nm_bts_site_mgr_fsm'? https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/bts.c File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/bts.c@224 PS1, Line 224: LOGL_INFO, NULL); alignment https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/bts.c@225 PS1, Line 225: bts_sm%d AFAIR, there can be only one site manager, it's not a per-BTS entity. It's the highest MO in the hierarchy. If I am not mistaken, we should allocate a single (global) instance and attach all BTS MOs/FSMs to it. https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/oml.c@1624 PS1, Line 1624: obj = bts I am not getting this... Site manager != BTS. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iab2d17c45c9642860cd2d5d523c1baae24502243 Gerrit-Change-Number: 20408 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Fri, 02 Oct 2020 21:05:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201002/89e770bd/attachment.htm>