Change in osmo-bsc[master]: pcuif_proto: version 10: add support for IPv6 NSVCs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Oct 2 18:46:16 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20294 )

Change subject: pcuif_proto: version 10: add support for IPv6 NSVCs
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/20294/3/src/osmo-bsc/pcu_sock.c 
File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20294/3/src/osmo-bsc/pcu_sock.c@209 
PS3, Line 209: 		info_ind->remote_port[i] = nsvc->remote.u.sin.sin_port;
Better move this into the switch and use proper field for each different family.


https://gerrit.osmocom.org/c/osmo-bsc/+/20294/3/src/osmo-bsc/pcu_sock.c@217 
PS3, Line 217: 			info_ind->remote_ip[i].v6 = nsvc->remote.u.sin6.sin6_addr;
Are you sure you are properly copying the sin6addr here? It's more than one word side, iirc implemented as an array...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20294
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I740be0a401612bb5ed4e8ccd7f4be8176b936449
Gerrit-Change-Number: 20294
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Oct 2020 18:46:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201002/82944f8f/attachment.htm>


More information about the gerrit-log mailing list