This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20386 ) Change subject: RSL/BSSAP: fix: properly convert between RSL Link ID and DLCI ...................................................................... Patch Set 2: (1 comment) the commit log could contain at least one sentence about what's happening here, i.e. what the bug is, how it shows up, ... https://gerrit.osmocom.org/c/osmo-bsc/+/20386/2/src/osmo-bsc/gsm_08_08.c File src/osmo-bsc/gsm_08_08.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20386/2/src/osmo-bsc/gsm_08_08.c@566 PS2, Line 566: OBSC_LINKID_CB so you are converting the RSL link_id to a DLCI and then store it in something called LINKID_CB? That looks confusing. I think you either store link_id in LINKID_CB and convert when reading, or you need to rename LINKID_CB to _DLCI_CB. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If4d479a54cad467f53b49065c1c435a4471ac7d2 Gerrit-Change-Number: 20386 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 01 Oct 2020 18:26:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/673dbdf8/attachment.htm>