This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373 ) Change subject: bsc: implement initial LCS tests for OsmoBSC ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn@4496 PS1, Line 4496: pri > it's needed in the new test TC_ho_during_lcs_loc_req where the lchan is moved to RSL1 I was thinking it could be separate, as you just introudced some other change to that function in a different patch, IIRC? Anyway, not critical. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn@7537 PS1, Line 7537: rivate function f_match_bsslap(PDU_BSSAP_LE got_bsslap_msg, : template (present) BSSLAP_PDU expect_bsslap) : { : var BSSLAP_PDU bsslap := dec_BSSLAP_PDU(got_bsslap_msg.pdu.bssmap.co_info.bsslap_apdu.data); : if (not match(bsslap, expect_bsslap)) { : log("EXPECTING BSSLAP: ", expect_bsslap); : log("GOT BSSLAP: ", bsslap); : setverdict(fail, "BSSLAP is not as expected"); : mtc.stop; : } : setverdict(pass); : } > ah? what's decmatch? grep for decmatch in the osmo-ttcn3-hacks.git for some examples. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn@7565 PS1, Line 7565: f > this is about getting log markers in the *osmo-bsc* stderr output, not the ttcn tester log. […] testcasename() returns the charstring of the current test case name. So yes, having one such call at one location in the code would probably be the way to go. thanks. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id3df9439752c088cff5618d21254af42365690ca Gerrit-Change-Number: 20373 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 01 Oct 2020 18:23:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/d183455d/attachment.htm>