Change in libosmocore[master]: add BSSMAP coding for Location Services

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Oct 1 18:13:45 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20335 )

Change subject: add BSSMAP coding for Location Services
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/20335/1/src/gsm/gsm0808.c 
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/c/libosmocore/+/20335/1/src/gsm/gsm0808.c@1363 
PS1, Line 1363: 	out = msgb_tl_put(msg, GSM0808_IE_IMSI);
              : 		rc = osmo_mobile_identity_encode_msgb(msg, &params->imsi, false);
              : 		if (rc < 0) {
              : 			msgb_free(msg);
              : 			return NULL;
              : 		}
              : 		/* write the MI value length */
              : 		*out = rc;
> the legacy mobile identity included the IEI value and tag length, which caused a lot of weird code. […]
you could even pass a TLV type into the function (like TL16V or so) to control the encoding.  Or have different functions like msgb_put_mobile_id_tl16v()



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20335
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4d7302a4853518916b6b425e710c10568eb2ffe5
Gerrit-Change-Number: 20335
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 01 Oct 2020 18:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/195f4d9a/attachment.htm>


More information about the gerrit-log mailing list