This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20234 )
Change subject: oml: encode IPv6 NSVC using the new OML attribute NM_ATT_OSMO_NS_LINK_CFG
......................................................................
Patch Set 10:
(5 comments)
https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c@775
PS9, Line 775: osmo_sockaddr_str_to_sockaddr(&remote, &nsvc->remote.u.sas);
> This should be osmo_sockaddr_str_from_sockaddr.
Ack
https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c@776
PS9, Line 776: if (nsvc->remote.u.sa.sa_family != AF_UNSPEC) {
> Maybe if (osmo_sockaddr_str_is_set()) ?
Not possible because is_set() also checks the port != 0.
https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c@782
PS9, Line 782: * port can be even configured when when the IP isn't */
> double when
Ack
https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c@3050
PS9, Line 3050: switch (remote.af) {
> Simply call osmo_sockaddr_str_to_sockaddr()
Can't use it because the port would be overriden.
https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bts_ipaccess_nanobts.c
File src/osmo-bsc/bts_ipaccess_nanobts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bts_ipaccess_nanobts.c@230
PS9, Line 230: if (osmo_bts_has_feature(&bts->features, BTS_FEAT_IPV6_NSVC) &&
> if (!osmo_bts_has_feature
ouch!
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20234
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6529876a3c1116a79dd624312243d8ae48a41fe2
Gerrit-Change-Number: 20234
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 18:09:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/20f44688/attachment.htm>