Change in libosmocore[master]: add osmo_float_str_to_micros and osmo_micros_to_float_str

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20331 )

Change subject: add osmo_float_str_to_micros and osmo_micros_to_float_str
......................................................................


Patch Set 1:

> Another approach could be using actual float and snprintf("%.5f")?
> IIRC we don't want float?

That was mostly a concern for the sysmoBTS1002 (and related) which were based on old ARM cores without any FPU, and hence had to jump through hoops to do float arithmetic.

As that platform is discontinued, and the probability of people wanting to use a OsmoBSC with Lb interface or even a SMLC there is super low, *and* the rate of SMLC messages (and ence float arithmetic) is very low, I think there is no constraint from a CPU/harware point of view to use float these days.

For reference, if you look at osmo-trx, it is full of float.

I'm not saying it's neccessarily a good thing to use float everywhere now, but if that's the natural representatoin for something, there is nothing preventing its use.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20331
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib9aee749cd331712a4dcdadfb6a2dfa4c26da957
Gerrit-Change-Number: 20331
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 17:53:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/9d1685ce/attachment.htm>